search

niftools / nifskope

A git repository for nifskope.
http://www.niftools.org
Other
555 stars 235 forks source link

Example Starfield .nif that gets corrupted by removing unused strings #254

Open JMPZ11 opened 2 weeks ago

JMPZ11 commented 2 weeks ago

(This is still happening using the latest dev as of 30 minutes ago, as well as before the qt6 upgrade)

I have run all the other optimizations, several times - I've tried internal and external geometry -- I can't remove unused strings - when reloaded the file is completely corrupt

gatesm_door01_hatchplugfloor03.zip gatesm_door01_hatchplugfloor03.afterremoveunused.zip

Sorry if this is the wrong place to submit issues!

fo76utils commented 2 weeks ago

I have a fix to this issue now, it was apparently caused by the model being updated while the spell is running, and BSLightingShaderProperty having conditionals based on the name being non-empty. Those could be broken by a state where the string index is temporarily pointing to the wrong string. So, I changed the code to disable updates until processing is complete.

JMPZ11 commented 6 days ago

Thanks!