search

niftools / nifxml

A repository for the nif.xml file, which contains the nif file format description.
http://www.niftools.org
GNU General Public License v3.0
37 stars 43 forks source link

SkyrimLayer wireframe colors #19

Open hexabits opened 10 years ago

hexabits commented 10 years ago

Commit: niftools/nifxml@959cb9c

... Has gotten rid of wireframe coloring for Skyrim collisions. For example, OL_STATIC is red, and SKYL_STATIC is green (the default presumably).

OK, the regression is actually because of the disabling of Oblivion Layer when User Version >= 12. NifSkope looks at that only.

Furthermore, it doesn't actually reference those colors in the

With all that said, maybe there's an opportunity to actually do something about this and do it right. :)

We could theoretically keep the core idea and change from:

<option value="1" name="OL_STATIC">Static (red)</option>

to

<option value="1" name="OL_STATIC" color="red">Static</option>

Or, more optimally:

<option value="1" name="OL_STATIC" color="#FF0000">Static</option>

While perfectly legible to me, maybe not to everybody. :)

OK, the simplest change is not naming them "Oblivion Layer" and "Skyrim Layer", etc. But keeping the Type name that way. NifSkope relies on the value being called "Layer" and I think the name should stay game-agnostic.

hexabits commented 10 years ago

[Main issue updated above] I'll be posting any commits to regression/collision-layers

Unfortunately just adding the colors in is not enough. The XML disables Layer (OblivionLayer) which is what NifSkope actually uses to determine color, not Layer Copy (now Skyrim Layer).

So this is now officially an incompatibility issue. I'll have to rewrite around this change in addition to adding the colors back in.

neomonkeus commented 10 years ago

Of the two options I would prefer to revert the changes such that they are one combined Collision Layer. I am generally against adding application specific data with the goal of removing all of the "NifSkope" & "Niflib" specific attributes in nif.xml.

That said, I think this would be useful generically for any application which would like to visual things. We should also test version conditioning on enums items.

hexabits commented 10 years ago

Like usual, I messed up updating my develop branch, so the Pull Request would not have been right. Redid it, so you can ignore the 0f65580 commit above.