search

niftools / pyffi

PyFFI is a Python library for processing block structured files.
http://www.niftools.org/pyffi
Other
48 stars 26 forks source link

Removed calls for the bs num uv set to match changes in nif xml #15

Closed Ghostwalker71 closed 9 years ago

Ghostwalker71 commented 9 years ago

I can create another pull to set the submodules pointing at the master branches. I hadn't noticed that either as I rarely even look at master. As for the diff, I honestly have no idea what that is all about.

"These name variable would need to be updated to be ExtraVertices." I don't think they do, as those calls were used to update the uv set count. I tested the changes as I made them and the exported files were correct. though I am unsure if those else statements still need to exist or if they are completely unneeded now. I was planning on doing some further testing later to determine if they can be removed.

neomonkeus commented 9 years ago

This is all the changes between the commit pyffi was pointing to and nifxml develop latest. - https://github.com/niftools/nifxml/compare/3ad328e8c493da1e0358231fe6fd2a20237351d7...niftools:develop Seems that commit in question is nifxml:master, but again having a fixed commit to reference means that if develop was merged to master and pyffi built it wouldn't fall over immediately.

If updating the commit pointer in a pull request, the accompany changes need to also be included.

Using git bash as github has a restriction on diff size. git diff 3ad328e8c493da1e0358231fe6fd2a20237351d7 develop

Ghostwalker71 commented 9 years ago

Would it not be easier to branch off of master and force update develop then I can generate a new commit and pull for the sub-modules links? There have been no pull requests other than mine.

Ghostwalker71 commented 9 years ago

Rebased and ready to merge, I've tested the changes thoroughly and am confident they are correct.

Ghostwalker71 commented 9 years ago

Until this is merged I will be unable to move forward on any further edits to the plugin, so when you find the time to actually look it over and realize that it does work, merge it then send me a message. If I'm not involved elsewhere I will see about making further advancements to the plugin.