niftools / pyffi

PyFFI is a Python library for processing block structured files.

http://www.niftools.org/pyffi

Other

47 stars 26 forks source link

Tests/inline doctest fix #42

Closed neomonkeus closed 7 years ago

neomonkeus commented 7 years ago

@niftools/pyffi-reviewer

Overview

Convert several tests from doctest to pure code using nose.

Fixes Known Issues

Includes fixes for havok material

Closes #37

Documentation

N\A

Testing

Tests are passing in automation

Manual

Run locally

Automated

Running through services on check in. Discovered strange issue that travis does not like us to remove the print(unittest...) Probably related to function not returning anything.

Additional Information

Moved most of the doctests from spells.
Simplified integration style tests which access file resources.

coveralls commented 7 years ago

Coverage increased (+13.8%) to 57.94% when pulling 13f524dc528498db4958b39ca48a5aea8d74b287 on neomonkeus:tests/inline_doctest_fix into 19eed0214a9726ccbba6556fd384becce3ac8712 on niftools:develop.

psi29a commented 7 years ago

You're on fire!

coveralls commented 7 years ago

Coverage increased (+13.8%) to 57.94% when pulling b65fbafea80f323d898304b37ed1666569389e2c on neomonkeus:tests/inline_doctest_fix into 19eed0214a9726ccbba6556fd384becce3ac8712 on niftools:develop.

psi29a commented 7 years ago

They keep coming! :D

neomonkeus commented 7 years ago

I created a branch, but didn't check it out. As it happened I came across some missing assertions so wanted to get them included anyways, The last push narrowed down the failed test cases which are not affected by #38

I am happy enough with what we have, current outstanding non-working doc_tests

'spells/egm/optimize.txt',
'formats/kfm/kfmtoaster.txt', #Not Implemented
various regression tests (outside documentation)
'docs-sphinx/intro.rst', #outside of test dir...

coveralls commented 7 years ago

Coverage increased (+14.08%) to 58.185% when pulling a3d0ff8ed709096b22bc020024d24fd9d48d9e79 on neomonkeus:tests/inline_doctest_fix into 19eed0214a9726ccbba6556fd384becce3ac8712 on niftools:develop.

psi29a commented 7 years ago

Nice work @neomonkeus