Issue Overview

Update check_centerradius for BS

Version Information

Pyffi Version Info

[version number] Run the following command if it is installed. python -c "import pyffi; print(pyffi.version)"

Platform information

I have latest PyFFI clone from git, compiled from source on Windows 10 with 32-bit Python 3.6.

Context

I have a bunch of NIFs that need their Bounding Spheres corrected. I was looking for some software that could do it. SSE NIF Optimizer supposedly has that feature but I tried it and the Bounding Spheres were unchanged. I found PyFFI and niftoaster and niftoaster has the spell check_centerradius which I believe will update the Bounding Sphere if all the vertices aren't inside it.

Steps to Reproduce

Run the check_centerradius on the provided file

Expected Result

The nif to be updated with the new bounding sphere where the vertices are read from the new block structure

Actual Result

[Describe what you currently experience from this process, and thereby explain the bug]

Possible Fix

[Optional, suggest fixes, improvement or reasons for the bug might have occurred]

Screenshot

[If relevant, include a screenshot]

Logs and Files

https://github.com/niftools/pyffi/files/1857827/bookset08.zip

Console Output

I get the following error:

pyffi.toaster:INFO:toasting with 8 threads in chunks of 256 files pyffi.toaster:45952:INFO:=== C:\Program Files (x86)\Steam\steamapps\common\Skyrim Special Edition\Data\meshes\Nix_Manor\run\bookset08.nif === pyffi.toaster:45952:ERROR:FAILED ON C:\Program Files (x86)\Steam\steamapps\common\Skyrim Special Edition\Data\meshes\Nix_Manor\run\bookset08.nif - with the follow exception pyffi.toaster:45952:ERROR:EXPT MSG : type object 'NifFormat' has no attribute 'BSTriShape' pyffi.toaster:45952:ERROR:If you were running a spell that came with PyFFI pyffi.toaster:45952:ERROR:Please report this issue - https://github.com/niftools/pyffi/issues

I'm running SSE btw.

Similar Known Issues

requires updating to nif.xml that support BSTriShape dependency #21

Additional Information

[Anything else you feel is relevant]

3blake7 commented 6 years ago

bookset08.zip

neomonkeus commented 6 years ago

@fractalfederation The version of pyffi you ran against doesn't currently support the version of the nif format that you are trying to optimize. In order to bump up to the latest version of our format description "nif.xml", there are several features improvements that need to be made, covered by other tickets, eg #21