niftools / pyffi

PyFFI is a Python library for processing block structured files.

http://www.niftools.org/pyffi

Other

47 stars 26 forks source link

Update KfmFormat #57

Closed TagnumElite closed 5 years ago

TagnumElite commented 5 years ago

@niftools/pyffi-reviewers

Overview

Quick list of changes

Updates the KfmFormat to work
Updated the kfmxml submodule
Update .gitignore (because I felt it...)
Fixed typo in MANIFEST.in
KfmFormat.Data() doesn't store the data anymore, it's attribute kfm does. (This is for any future changes to the kfmxml not causing you to need to update the code)
Add config settings for pytest to setup.cfg
Change the test_logger to store a file.
Removed kfmtoaster.txt because it wasn't doing anything and moved to test_kfmtoaster.py
Moved the files around in preparation for neo's Refactor/Doctest pull
Update old doctests for KfmFormat to work with changes.

Updated the KfmFormat, this change isn't backward compatible but could be made backward compatible.

Fixes Known Issues

Should Resolve #40

Documentation

N/A Updates

Testing

Added KfmToaster testing using spells

Manual

N/A

Automated

test_kfmtoaster.py was added to run already existing spells.

Todo

[x] Add more tests
[x] Improve pull request description
[x] Update test_logger file_handler to actually role over
~Update Code Coverage to 100% for the KFM Format~ Not gonna work, not all code is run

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 58.244% when pulling 382f59eba36c1e9b113105dcf793434b877ea9a3 on TagnumElite:fix_kfm into 46a68cb2628e6778e3cd574a44f8cc1080604b6c on niftools:develop.

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 58.244% when pulling 382f59eba36c1e9b113105dcf793434b877ea9a3 on TagnumElite:fix_kfm into 46a68cb2628e6778e3cd574a44f8cc1080604b6c on niftools:develop.

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 58.244% when pulling 382f59eba36c1e9b113105dcf793434b877ea9a3 on TagnumElite:fix_kfm into 46a68cb2628e6778e3cd574a44f8cc1080604b6c on niftools:develop.

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 58.259% when pulling 3595fed86591b935d42e2d6247411db5080bba95 on TagnumElite:fix_kfm into 46a68cb2628e6778e3cd574a44f8cc1080604b6c on niftools:develop.

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 58.244% when pulling 382f59eba36c1e9b113105dcf793434b877ea9a3 on TagnumElite:fix_kfm into 46a68cb2628e6778e3cd574a44f8cc1080604b6c on niftools:develop.

neomonkeus commented 5 years ago

I fixed the coveralls integration, generally when porting between docstrings and defined tests, there is a drop, but not bother about it as its usually the abstract methods that don't get covered.

TagnumElite commented 5 years ago

Yeah, a way to fix that is using # pragma: no cover or writing tests for every single little thing.