niftools / pyffi

PyFFI is a Python library for processing block structured files.
http://www.niftools.org/pyffi
Other
47 stars 26 forks source link

Python 3.7 Support #61

Closed HENDRIX-ZT2 closed 4 years ago

HENDRIX-ZT2 commented 4 years ago

@niftools/pyffi-reviewers

Issue Overview

Iterators choke on next() methods because StopIteration is no longer silent. https://www.python.org/dev/peps/pep-0479/

Possible solution: a) wrap next() calls into try/except clauses b) rewrite iterators to use for loops to avoid next()

Travis passes because option b) was applied to the one instance of this issue that was covered by tests, but there are more. Check all next() calls!

Version Information

Pyffi Version Info

current develop

Platform information

[Provide a brief overview of what OS your running on]

Context

[Provide more detailed information to the issue itself]

Steps to Reproduce

[Ordered list of the steps required for recreating the issue, including settings]

.

Expected Result

[Describe what you expected to have resulted from this process]

Actual Result

[Describe what you currently experience from this process, and thereby explain the bug]

Possible Fix

[Optional, suggest fixes, improvement or reasons for the bug might have occurred]

Screenshot

[If relevant, include a screenshot]

Logs and Files

[Provide the generated log output and any accompanying files for the format related to the issue]

Console Output

[Set the logging level to 'Debug' and attach the output of the console. ]

Similar Known Issues

[Reference any known issues - https://github.com/niftools/pyffi/issues]

Additional Information

[Anything else you feel is relevant]

HENDRIX-ZT2 commented 4 years ago

Closed by #64