niftools / pyffi

PyFFI is a Python library for processing block structured files.
http://www.niftools.org/pyffi
Other
48 stars 26 forks source link

Implement Center/Radius algorithm #71

Open neomonkeus opened 8 years ago

neomonkeus commented 8 years ago

See niftools/nifskope#69

HENDRIX-ZT2 commented 4 years ago

Consistency flags are set and retrieved correctly already. Center and radius of exported trishapes are set with suitable accuracy as well. If anything, this is a pyffi issue, see this line in export_tri_shapes(): tridata.update_center_radius()

Looking at the source, pyffi does not check for mesh flags or version number: https://github.com/niftools/pyffi/blob/7f4404dbb8cf832dadd4b3150819340b8764f9b0/pyffi/formats/nif/__init__.py#L4417

So this issue can be closed here. We might want to transfer it to pyffi to implement the nifskope-style version check there.