niftools / pyffi

PyFFI is a Python library for processing block structured files.
http://www.niftools.org/pyffi
Other
47 stars 26 forks source link

Set node name for ControllerLink with StringPalette #77

Open HENDRIX-ZT2 opened 2 years ago

HENDRIX-ZT2 commented 2 years ago

@niftools/pyffi-reviewers

Issue Overview

All controller links should set on the parent controller's palette. Don't create a palette for each controller link.

see https://github.com/niftools/blender_niftools_addon/pull/463 for a fix on the blender plugin side

Version Information

Pyffi Version Info

current master / dev

Platform information

[Provide a brief overview of what OS your running on]

Context

[Provide more detailed information to the issue itself]

Steps to Reproduce

[Ordered list of the steps required for recreating the issue, including settings]

.

Expected Result

ControllerLink.set_node_name() should set: self.target_name (for older games that do not use the palette) self.node_name self.node_name_offset and write to a shared palette

Actual Result

the linked pyffi for the plugin does not set self.target_name a new palette is created for each controlled block

Possible Fix

[Optional, suggest fixes, improvement or reasons for the bug might have occurred]

Screenshot

[If relevant, include a screenshot]

Logs and Files

[Provide the generated log output and any accompanying files for the format related to the issue]

Console Output

[Set the logging level to 'Debug' and attach the output of the console. ]

Similar Known Issues

[Reference any known issues - https://github.com/niftools/pyffi/issues]

Additional Information

[Anything else you feel is relevant]