nigelheng / pe

0 stars 0 forks source link

Smart feature error message misleading #5

Open nigelheng opened 4 months ago

nigelheng commented 4 months ago

image.png The error message when using the smart feature says to enter yes, no or cancel the generation process, yet cancel is not accepted as an input.

nus-pe-script commented 4 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error message unclear (smart)

smart
Here is a smart itinerary for your date (the afternoon is planned around your base preferences!):
We begin with lunch at Westside Wraps, followed by some fun at Jurong Hill Lookout Tower.
We proceed to have dinner at Spicy Dragon, and finish the night at Siloso Beach Bars Evening Out.

Are you satisfied with the date idea? [Yes/No]
N
Sorry, I didn't quite understand that :(
Please enter either yes or no or cancel the generation process
____________________________________________________________

Instructions on either yes, no or cancel are unclear. Error message structure does not properly convey that cancel will cancel the generation process. Users may end up typing cancel the generation process though as ridiculous as it may sound.

It was done correctly in other instances such as:

____________________________________________________________
list
Looking for ideas to spice up your date night?
Choose from the following options:
1. List out delicious dining options (type 'food')
2. Discover exciting activities to do together (type 'activities')
3. Unwrap joy with our curated list of gifts that'll make hearts flutter! (type 'gifts')
4. Changed your mind? Feel free to cancel this command! (type 'cancel')
What's your pleasure?
____________________________________________________________
2
Invalid option! Please choose 'food', 'activities', 'gifts' or 'cancel'.

[original: nus-cs2113-AY2324S2/pe-interim#2500] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We thought that it's okay because it was clear that only a "Yes" or "No" was expected due to the square brackets right next to the question, but agree that the error message could be made clearer! Screenshot 2024-04-20 at 2.31.53 PM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]