search

nigelhorne / ged2site

Create a family tree website from a Gedcom file
https://genealogy.nigelhorne.com
GNU General Public License v2.0
36 stars 4 forks source link

static-site: All women are now "GivenName SurName (née MaidenName)" #123

Closed jhannah closed 3 weeks ago

jhannah commented 1 month ago

Hmm, something has gone sideways in master 01a2602796c30ce7ca021f0b89c937722d345c0b. e.g.: http://jays.net/genealogy/static-site/I2310.html

nigelhorne commented 1 month ago

That's surprising, given that particular commit backed out of the change which could have caused this problem. Can you confirm it was that commit, not one just before it, which caused that? I am unable to reproduce.

jhannah commented 1 month ago

Huh. For whatever reason, I'm having to add this to get multiple browsers to render it correctly:

<html>
<head>
  <meta charset="utf-8">
nigelhorne commented 1 month ago

That shouldn't be needed, since the code should emit <ampersand e acute ;> (changed to stop GitHub from rendering what I type) for that character. Try as I might, I can't reproduce this at the moment.

nigelhorne commented 1 month ago

Are you using a fork or my master? If a fork, please check that the code in wide_to_html() is up-to-date with the master. If it's the master, can I borrow a brick wall to hit my head against? This just doesn't make sense.

jhannah commented 4 weeks ago

Ya, apologies, I was completely mystified by this. When I ran cat on macOS or Debian Linux, I saw Sharon Erlene Hannah (née Humphrey). It looked fine. Using vim on macOS and Debian it looked fine. Then I'd load it in my web browser (3 different devices) and get the crazy characters (locally on macOS, and after moving the files to Debian Linux). I have lots of brick walls here, I was using them. 🙂 I shoved <meta charset="utf-8"> into the .html files, and the problem went away (branch 123-utf-8 in my fork). I can try again off your new master the next time I run it and see if my hacks can be thrown away.

jhannah commented 3 weeks ago

master 839a2e457d5ae3d8ebbad92b6469427ed52a8930 appears to have deprecated my 123-utf-8. 🎉

nigelhorne commented 3 weeks ago

Ged2site aims to be ASCII wherever possible, so it's useful to know that you no longer need to add the UTF-8 header.