search

nigelhorne / gedcom

Gedcom utility program
GNU General Public License v2.0
22 stars 7 forks source link

`Gedcom::Individual::relationship`: Add step-relationships #97

Open tukusejssirs opened 4 years ago

tukusejssirs commented 4 years ago

In Gedcom::Individual::relationship, you missed step-brother and step-sister. Difference between half-sibling and step-sibling is that half-siblings have one common parent, where step-siblings none.

I could create a PR with the following code added:

if(($self->mother() ne $other->mother()) && ($self->father() ne $other->father())) {
  return ($sex eq 'M') ? 'step-brother' : 'step-sister';
}

but when is the following code used?

return $self->relationship_down($other) || $self->relationship_up($other);

nigelhorne commented 4 years ago

This can only be done if step-mother and/or step-father relationships are worked out. Which currently they are not.

tukusejssirs commented 4 years ago

I’ll look at it out tomorrow (CEST).