search

night-ghost / minimosd-extra

Full rework of minimosd-extra with lots of news
163 stars 80 forks source link

NMEA Fix some issues and errors I found #200

Closed mrsima closed 7 years ago

mrsima commented 7 years ago

NMEA.h still do not work correct and do not shows correct Lan/Lon and are not usable. It seems function "GPS_calc_longitude_scaling()" do not work correct too.

mrsima commented 7 years ago

Can somebody help please?

Does function "parse_NMEA_char()" should set "osd_pos.lat" and "osd_pos.lon" as int32_t or float? See below <-> |----> case '\r': .... if (frameOK); // move GPS data to OSD data osd_pos.lat = msg.nmea.lat; <-> ((float)msg.nmea.lat) / 10000000.0f ; <-> gps_norm(osd_pos.lat,msg.nmea.lat); osd_pos.lon = msg.nmea.lon; <-> ((float)msg.nmea.lon) / 10000000.0f ; <-> gps_norm(osd_pos.lon,msg.nmea.lon); osd_pos.alt = osd_alt_mav = msg.nmea.alt 10; eph = msg.nmea.hdop 10; osd_heading = msg.nmea.course; osd_groundspeed = msg.nmea.speed; osd_fix_type = msg.nmea.fix; osd_satellites_visible = msg.nmea.sats; day_seconds = msg.nmea.time; // msg.nmea.date; | <----

Regards

mrsima commented 7 years ago
night-ghost commented 7 years ago

But nothing that I'm also not a programmer? If you are already saying that I do bugs, then you should not add a lots of new ones, do you? In this PR I saw only one bug fixed - an error in the CRC. And for some reason it seems to me that it is little not my :)

mrsima commented 7 years ago 
 I see, I am making you angry with my words. This was not my wish and I am sorry about that. Can you accept my apologies? Also, my English is not so god and I can not express so well in it.

You are not programmer? My mistake again. As I understand, most of NMEA code you get from ScarabOSD, so some errors I found are not yours, Scarabs are. I am not willing to make bugs too. I makes code changing, experiments and test it for a tenths of times and make some progress. All this I made without any C programming knowledge. It is logical that I have to make bugs too. Yes, I made CRC error when typing code, not you, this is normal and I am not angry about that. This was not my purpose, this was typo. Please lets try to make it work correct. This is my only wish. Best Regards

mrsima commented 7 years ago

Let me be wrong, I am C beginner and it have to be allowed to me. Let see at my github mrsima/first-try what I made for testing NMEA parsing. Download it and try it as described at README. Result of conv you can test at online coordinate testers and see the original code is wrong. That's all I know. Thanks. link is: https://github.com/mrsima/first-try/

night-ghost commented 7 years ago

You are not programmer? My mistake again.

Yes, I'm not a programmer. I am a system architect, my job is to give the task to programmers. But in the open sourсe I try to use the skills that got many years ago.

I am C beginner

so you chose a wrong place to train