search

night-ghost / minimosd-extra

Full rework of minimosd-extra with lots of news
163 stars 80 forks source link

ILS direction #225

Open mric3412 opened 6 years ago

mric3412 commented 6 years ago

ILS for plane is not working when you want to land in the same direction than for takeoff Planes generaly takes off and lands in the same direction (case of constant wind's direction) An ILS working in all approach's direction would be a good option in most cases. VERSIONS : v943 / v942 (older versions not tested) BOARD TYPE : Minim OSD V1.1 (ATMEGA328 and MAX7456)

night-ghost commented 6 years ago

required files?

mric3412 commented 6 years ago

It can be tested with the following tlog file log.zip Select only the ILS option of the HUD panel to clearly observe the ILS behavior : very hard (impossible?) to get the pair of horizontal and vertical lines (arrows suggesting to take another direction are very rarely absent)

mric3412 commented 6 years ago

I modified showILS() in Panels.h (ILS far less accurate is more useful in my case) I regressed the code to v936 concerning grad_to_sect() (just trying to fix radar and arrow_home_direction issues) These modifications are attached in the following zip file (with a new charset 2.4.1.5.1 : minor mods of 2.4.1.5 for radar, rssi, sat, TOTal dist icons etc.) It's just for tests (I didn't have the time to test it on the field : .hex for Mavlink is in dir buided_bin/, new charset is in dir charset/, ADSB is desactivated) v943_fusion936.zip

night-ghost commented 6 years ago

waiting for your PR

mric3412 commented 6 years ago

I tested in flight ILS (for plane) with softer angle constraints to display more easily horizontal and vertical lines of ILS (without softer constraints, these lines were too rarely displayed to be tested). Now it seems to me that ILS disfunctions. For example, look at the current version of Panels.h (line 305) : if the plane is aligned with the runway, we want vertical lines at the middle of HUD <=> lineposition=totalNumberVertLines/2 <=> currentAngleDisplacement=0. But, because of line 309, 0degres will become -180degres. In v857, Panels.h@286 currentAngleDisplacement==0 => linePosition==(totalNumberOfLines/2). So it seems OK until v857 but it seem's to me that giving the possibility to use ILS in opposite direction introduced a bug.

night-ghost commented 6 years ago

Thanks, will see