night-ghost / minimosd-extra

Full rework of minimosd-extra with lots of news
163 stars 80 forks source link

Delta Values & Wrong Flightmode #230

Closed tops4u closed 6 years ago

tops4u commented 6 years ago

Issue details

Values like Altitude, Distance, Power Used etc are delta calculated Values instead of decoded Values from the MAVLINK Datastream (where this information is available). To proof this, I have a case where there was a short interrupt in the Power Supply (5v) to the OSD during a Mission Flight. Check Screenshot just before the Outage:

image

And afterwards:

ohne titel

As you can see several Values (Altitude!!, Distance flown, Distance to Home, Power Used!!, Flight Time,...) have been reset. Just to note that the Flightmode selected was Mission and not RTL.

Version

R934 MAVLINK PX4

Board type

MicrominimOSD

How "canonical" OSD firmware works?

[ ] Works fine [ ] The same bug [X] Not applicable [ ] Not tested

TLOG and OSD

night-ghost commented 6 years ago

this is feature.

tops4u commented 6 years ago

Please don't let me die stupid... what is the use of this?

night-ghost commented 6 years ago

MAVlink stream don't contains this data so they are calculated by OSD itself.

tops4u commented 6 years ago

Not completely true. Altitude (Above Ground) as well as Current Consumed are available in PX4 Mavlink Stream. I concur that Travel Distance, Distance to Home and Home Alt are not in the Mavlink Stream. However IMHO the vital Flight Data (like ALTITUDE! and a little less the Current Consumed) should always be taken from the stream instead of being calculated by the OSD.

night-ghost commented 6 years ago

Really? you could fix it yourself, PRs are welcome. Did you read a license?