search

night / betterttv

BetterTTV enhances Twitch with new features, emotes, and more.
https://betterttv.com
Other
1.21k stars 267 forks source link

BTTV emote description cut off in chat replay #2411

Closed runer112 closed 7 years ago

runer112 commented 7 years ago

Specifically in the chat replay for VODs (not the live chat for streams), the emote description that shows up when hovering over a BTTV emote gets cut off by just about any other page element, including other lines of text:

bttv_2295

Originally mentioned in #2295, but this seems to warrant a separate issue.

EhsanKia commented 7 years ago

Hmm, tooltips in vods now show downwards... In vanilla twitch too.

I'm guessing this was actually a Twitch problem, and the way they fixed it is by making the tooltip open downwards instead... Wow.

runer112 commented 7 years ago

What is the resolution of this issue? It's not tagged with something like invalid/cantfix/wontfix, but there's also no linked commit fixing the issue.

EhsanKia commented 7 years ago

It was a twitch issue and they "fixed" it by making the tooltip pop under. Is that not the case for you?

runer112 commented 7 years ago

Yes, that is the case for me. Twitch's emotes use this "fix" so are fine. BTTV emotes do not use this fix, so are not fine, as demonstrated in the screenshot.

EhsanKia commented 7 years ago

Oh, right. My bad I misunderstood the issue, sorry.

elevenletters commented 7 years ago

Why is this closed? The issue still hasn't been fixed.

night commented 7 years ago

This is as good as it gets for now.

runer112 commented 7 years ago

Why can this not be fixed? The description hover works fine for BTTV emotes in live chat, so BTTV emotes don't inherently have a problem. And it works fine for non-BTTV emotes in chat replay, so chat replay doesn't inherently have a problem. Combined, it seems rather unlikely that there is an inherent problem preventing this from working.

night commented 7 years ago

The issue was fixed, and broke with a Twitch update. It's refixed in master, not yet deployed. Open a new issue in the future...