night / betterttv

BetterTTV enhances Twitch with new features, emotes, and more.
https://betterttv.com
Other
1.21k stars 267 forks source link

Raiding seems different #6589

Closed Lilykoi closed 8 months ago

Lilykoi commented 8 months ago

Describe the bug

I was modding for a streamer and he was raiding out. I did not see the raid banner/count down as usual so the stream just changed to the channel where the streamer set the raid to. As a viewer, same thing. No Raid banner count down. I am on desktop so it obviously shows on mobile. I check my settings and "Auto Join Raid" is present and toggled. I never seen this before. I disable it and waited in a stream for a raid out. The Raid banner count down popped up, then disappeared, and I did not get raided out. I do not watch Twitch on my phone.

Steps to reproduce

Disable Auto Join Raids and see if you get left behind in a stream. Raid banner is displayed but then disappears. Viewer is left in an offline stream.

Expected behavior

Disable Auto Join Raids and see if you get left behind in a stream. Raid banner is displayed but then disappears. Viewer is left in an offline stream.

Screenshots

I have no screenshots

Device information

Chrome v 121.0.6167.86

Additional information

Started on Jan 18, 2024

night commented 8 months ago

After reviewing our Auto Join Raid logic, I don't see how this could be possible. When the setting is turned on, the logic which listens for the raid is removed. Even if it were another setting hiding the UI, that wouldn't cancel you from joining the raid.

Do you happen to use other Twitch browser extensions?

Lilykoi commented 8 months ago

No. I already tried the option of the "Community Highlights" via the Discord to enable it, even though I had it disabled for a very long time. Apparently it is working now.

On Fri, Jan 26, 2024 at 9:14 PM Zack @.***> wrote:

After reviewing our Auto Join Raid logic, I don't see how this could be possible. When the setting is turned on, the logic which listens for the raid is removed https://github.com/night/betterttv/blob/master/src/modules/auto_join_raids/index.js#L20-L22. Even if it were another setting hiding the UI, that wouldn't cancel you from joining the raid.

Do you happen to use other Twitch browser extensions?

— Reply to this email directly, view it on GitHub https://github.com/night/betterttv/issues/6589#issuecomment-1913000639, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHCAEDIQSK3AULLEJX7EKRDYQSELXAVCNFSM6AAAAABCJW3H36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGAYDANRTHE . You are receiving this because you authored the thread.Message ID: @.***>

-- ~ Lilykoi “I'd say thistles, but nobody listens to me, anyway

night commented 8 months ago

Glad to hear it's working again. Let us know if it happens again!

github-actions[bot] commented 5 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related issues or feature requests.