Sync upstream (July edition)

[tw0po1nt]

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

• [x] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
• [x] Does the code abide by the Coding Guidelines?
• [x] Automated tests: Did you add appropriate automated tests for any code changes?
• [x] Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
• [x] Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
• [x] Run the app: Did you run the app and try the changes?
• [x] Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
• [x] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

• [x] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
• [ ] Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
• [ ] Automated tests: Did you review the automated tests?
• [ ] Manual tests: Did you review the manual tests?_You will find manual testing guidelines under our manual testing section_
• [x] How is Code Coverage affected by this PR? _We encourage you to compare coverage before and after your changes and when possible, leave it in a better place. Learn More..._
• [ ] Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
• [ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

[BostonZcash]

This is looking good from what functionality is available to test.

However, upon leaving one instance to sync unattended (new wallet > skip backup), I did run into:

Error: The operation couldn't be completed. (ZcashLightClientKit.ZcashError error 7.)

Quitting and re-opening the application allowed it to start and quickly sync as expected.

2023-07-09 15:14:33.600786-0400 secant-mainnet[37130:427638] [logs_default] [ERROR 💥] CompactBlockProcessor.swift - severeFailure(_:) - Line: 898 -> show stopper failure: serviceGetInfoFailed(ZcashLightClientKit.LightWalletServiceError.timeOut)
2023-07-09 15:14:33.661240-0400 secant-mainnet[37130:396550] [tcaLogs] received action:
  RootReducer.Action.nhHome(
    .synchronizerStateChanged(
      SynchronizerState(
        syncSessionID: UUID(09687FDD-07C4-475D-ABF0-8ACDC639E793),
        shieldedBalance: WalletBalance(
          verified: Zatoshi(
            _amount: Clamped(
              value: 0,
              range: -2100000000000000...2100000000000000
            )
          ),
          total: Zatoshi(
            _amount: Clamped(
              value: 0,
              range: -2100000000000000...2100000000000000
            )
          )
        ),
        transparentBalance: WalletBalance(
          verified: Zatoshi(
            _amount: Clamped(
              value: 0,
              range: -2100000000000000...2100000000000000
            )
          ),
          total: Zatoshi(
            _amount: Clamped(
              value: 0,
              range: -2100000000000000...2100000000000000
            )
          )
        ),
        internalSyncStatus: .error(
          .serviceGetInfoFailed(.timeOut)
        ),
        syncStatus: .error(
          .serviceGetInfoFailed(.timeOut)
        ),
        latestScannedHeight: 2150251,
        latestBlockHeight: 2150251,
        latestScannedTime: 1688929885.0
      )
    )
  )
  RootReducer.State(
    _alert: nil,
    appInitializationState: .uninitialized,
    debugState: RootReducer.DebugState(rescanDialog: nil),
    destinationState: RootReducer.DestinationState(…),
    exportLogsState: ExportLogsReducer.State(…),
    nhHomeState: NHHomeReducer.State(
      _destination: .wallet,
      requiredTransactionConfirmations: 10,
      latestMinedHeight: 2150251,
      shieldedBalance: Balance(…),
      transparentBalance: Balance(…),
      synchronizerStatusSnapshot: SyncStatusSnapshot(
-       message: "Preparing to scan",
+       message: "Error: The operation couldn’t be completed. (ZcashLightClientKit.ZcashError error 7.)",
-       syncStatus: .syncing(0.0)
+       syncStatus: .error(
+         .serviceGetInfoFailed(.timeOut)
+       )
      ),
      walletEvents: [],
      walletState: WalletReducer.State(…),
      transferState: TransferReducer.State(),
      settingsState: NHSettingsReducer.State(…)
    ),
    homeState: HomeReducer.State(…),
    onboardingState: OnboardingFlowReducer.State(…),
    phraseValidationState: RecoveryPhraseValidationFlowReducer.State(…),
    phraseDisplayState: RecoveryPhraseDisplayReducer.State(…),
    sandboxState: SandboxReducer.State(…),
    storedWallet: StoredWallet(…),
    walletConfig: WalletConfig(…),
    welcomeState: WelcomeReducer.State()
  )