search

nighthawk-apps / nighthawk-wallet-android

Old version of Nighthawk Android Wallet. No longer maintained.
https://nighthawkwallet.com
Apache License 2.0
33 stars 14 forks source link

Idea: Allow users to choose which txns to collect memos for #13

Open ChileBob opened 4 years ago

ChileBob commented 4 years ago

Is your feature request related to a problem? Please describe.

Lightwalletd can 'learn' which txns belong to a client by watching which ones they collect memos for.

Memos are nice, but they're not essential.

Describe the solution you'd like

A user defined 'filter' so users can set a limit (in ZEC), if a txn is less/more than the limit then the memos are not automatically fetched from the server. A tickbox 'dont automatically collect memos' would also work.

Describe alternatives you've considered

The transaction list could also allow the memo to be fetched for a specific transaction.

nighthawk24 commented 4 years ago

That's a great initiative @ChileBob FYI Nighthawk's lightwalletd server has logging turned off and does not 'learn' about transactions by clients or nodes connecting to it. Nighthawk Wallet also has the feature to change lightwalletd server to your own hosted one where you can be assured of no server side analytics being run.

As for the feature, I can look in to this when I have bandwidth available. Additionally, Kevin from ECC is going to set up a Light Clients working group where we can go over this feature ask.

ChileBob commented 4 years ago

A further thought... collecting memos could depend on which lightwalletd you're connected to.

End result would be while out & about (ie: on mobile) your wallet uses a public server so does not collect memos by default, when at home (ie: on wifi & server is reachable on a rfc1918 address) the wallet switches server & checks/collects memos for all transctions (ie: catches up).

gmale commented 4 years ago

These are interesting ideas! An app could also incorporate geofencing and change behavior, based on location (don't send any transactions when I'm outside of my house. Never load memos while I'm at work.).

Currently, this might be a bit moot because the app doesn't do anything unless its in the foreground. Background sync is a feature that we're currently researching for how to add at the SDK level so that all wallets can benefit.