search

nighthawkcoders / portfolio_2025

Nighthawk Pages 3.0. This is a GitHub Pages project that includes support for Jupyter Notebooks. The project provides a game, lessons and projects to support the teaching of Career Technical Educations and AP courses: Computer Science and Software Engineering (CSSE), Computer Science Principles (CSP), and Computer Science A (CSA).
https://nighthawkcoders.github.io/portfolio_2025/
Apache License 2.0
0 stars 86 forks source link

Javascript Strings | Nighthawk Pages #221

Open utterances-bot opened 1 week ago

utterances-bot commented 1 week ago

Javascript Strings | Nighthawk Pages

Gain and understanding of how strings work

https://nighthawkcoders.github.io/portfolio_2025/csp/big-idea/p2/3-4-1

CanadianPotatoe commented 1 week ago

Love the Green Text, however we can't see your white text in the white boxes; Please convert your HTML document to a Markdown Cell for easier reading

jm1021 commented 6 days ago

We need to forbid the usage of head and body tags in our examples. But, since you used them we could make a discussion on 'why not to use them'. This is related to CandianPotatoe comment on white boxes.

XavierTho commented 5 days ago

You guys were obviously super dedicated, as can be denoted by your many comprehensive examples! However, there are certain parts of this lesson that are restricting it from being the best possible lesson.

Number 1: As Mr. Mortensen and Kanhay (CanadianPotatoe) pointed out, much of your code is covered in white boxes, which greatly inhibits our ability to readily go through your examples. Likewise, reiterating what Mr. Mortensen said, the usage of head and body tags just serves to clutter your code and make it harder for us to decipher where in the code is your actual example.

Number 2: You seem to have mistaken the point of the lesson. We are trying to learn about JavaScript strings, but for a large portion of this lesson, you talk about Java strings. There is a difference. A pretty big one at that. So, that is something that needs to be fixed ASAP

Number 3: You have lots of code and minimal explanation on the code, so consider elaborating more on the code rather than having 90%+ of the lesson be examples.

Darsh220 commented 4 days ago

I feel that you could remove the Head, Body and HTML tags from your code to make it more clear and easy to understand. You could also make your content more concise since the lessons won't be long. However, I like the customization of text in your titles and I like how it matches the overall theme of the page.

zachpeltz commented 4 days ago

There is a lot of code and work shown but there are still many formatting errors like the html and body tags and white highlighted text which you should try to fix.

derekkang1 commented 1 day ago

I like your custom styling and colors but I suggest applying it to all the notebook under 3.4 to keep things consistent. The content being covered is very good but there seems to be a lot of code, maybe you guys could split up the long areas into smaller sections to explain easier then put it all together. Otherwise great job!