search

nightingale-media-player / nightingale-addons

Add-ons for Nightingale
6 stars 4 forks source link

Add MinimizeToTray++ addon #17

Open darealshinji opened 10 years ago

darealshinji commented 10 years ago

I know this addon is available on the Nightingale homepage, but that's not the newest version and you have to modify it so it works with 1.12.2a (Linux) or newer builds. The current source code: svn co http://svn.codefisher.org/svn/minimizetotray/

thebecwar commented 10 years ago

Don't know if this actually needs to be in our repo. Right now we're only hosting the source for a few key addons, and I'm not sure that this is an addon we want to maintain. I believe that the only addons we are hosting the source for are the ones that POTI were building internally. (Someone who's been here a while could probably confirm this.)

That said, if someone builds an xpi, I'd be happy to swap over the version on the wiki. We should eventually streamline the process of updating these, but until then I'll put a contact link on the wiki add-ons page to this issue tracker so extension developers can request to have their extensions updated.

clokep commented 10 years ago

FYI I'd suggest using MinTrayR: https://tn123.org/mintrayr/ / https://github.com/nmaier/mintrayr/ He might even be willing to add Nightingale to install.rdf...

darealshinji commented 10 years ago

@clokep I added NG to install.rdf and built it, but It doesn't work for me on NG 1.12.2a. I've tried it with the pre-built libraries and with the one I built myself. It installs, and I can configure it, but when I close NG it really closes instead of minimizing into the tray. ;_; Checked the task manager, it's not there anymore, so it's not a problem with the icon not appearing.

clokep commented 10 years ago

I didn't make that extension, I can't debug it. I know we have a version of it built into Instantbird. It's possible the version you're building is not compatible with the version of Gecko you're using or that the options aren't configured properly.

rsjtdrjgfuzkfg commented 10 years ago

@thebecwar I agree that we should not put it into this repo. However, we track many add-on issues in this issue tracker, without considering merging.

Also, the current policy is that everybody can get edit privileges by contacting GeekShadow, to update his/her add-ons on their own. That is far from perfect, but ilikenwf and I didn't have that much free time lately to continue on featherweight.

darealshinji commented 10 years ago

I added version 1.0.10b to the wiki. I left the download link of 1.0.9 since that one also has Windows support (dunno how to compile win binaries, nor am I in the mood to do so). I've updated some of the plugins from nightingale-media-player/nightingale-addons there too, i.e. g15simple or web-window.