search

nightingale-media-player / nightingale-deps

Nightingale build deps - Windows, Linux, Mac - all the sources right here (for now)
http://getnightingale.com/forum/
23 stars 14 forks source link

Is the Mozilla gst plugin needed? #16

Closed freaktechnik closed 10 years ago

freaktechnik commented 10 years ago

While looking through the failing unittests I noticed, that we are missing a gst plugin containing "mozilla". A little research led me to this. It seems that it exposes a gst pipe as XPCOM output stream? If it enhances our functionality, we should have it in our ppa and depend on it and ship it with all other ngale versions.

johnmurrayvi commented 10 years ago

Hmm.... For Linux, the Gstreamer stuff isn't built at all. I wonder if gst-plugins-bad generally includes the Mozilla plugin when it's distributed.

mook commented 10 years ago

The Mozilla gst plugin is Songbird/Nightingale specific. It's basically used to pull data from the Mozilla network stack, so you get things like correct cookies, IIRC. Pretty sure not having it would be a bad idea.

freaktechnik commented 10 years ago

Well, our linux builds already live without it. So we need to restore it for linux and start bundling it with linux builds and optimally make it a dependency in the Ubuntu PPA.

johnmurrayvi commented 10 years ago

With the newer xul branch moving to gstreamer-1.0 and having it be bundled with all of the builds, are there any other gstreamer packages/plugins that should be looked at?

johnmurrayvi commented 10 years ago

Can this be closed now since it's in the nightingale-hacking tree? Or do you want to keep it open and have it be part of the deps on newer xulrunner versions?

freaktechnik commented 10 years ago

I think we can close this here, as we build gstmozilla with nightingale now.