Open darealshinji opened 9 years ago
Firt of all, you will surely get a valid UTF8 string from a NS_ConvertUTF16toUTF8
object. Further it doesn't seem as if the gtk_window_set_title
method supports three arguments: https://developer.gnome.org/gtk2/stable/GtkWindow.html#gtk-window-set-title
P.S.: Direct link to the source where the warning origins from: https://github.com/nightingale-media-player/nightingale-deps/blob/xul-192-new/xulrunner-1.9.2/mozilla/widget/src/gtk2/nsFilePicker.cpp#L411
Any idea how to fix the remaining
[-Wformat-security]
warning inxulrunner-1.9.2/mozilla/widget/src/gtk2/nsFilePicker.cpp
? I don't really know if putting a"%s",
in front ofNS_ConvertUTF16toUTF8
is the correct way to do this here. https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wformat_-Wformat-security