nightingale-media-player / nightingale-hacking

Working tree for the community fork of Songbird, Nightingale. If building, use the sb-trunk-oldxul (development) branch, with the tag 1.12.1 tag for stable, for now. The master-xul-9.0.1 branch is the current progress in building Nightingale with XULRunner 9 and builds, but is broken. All help in terms of patches and pull requests is welcome.
https://getnightingale.com
GNU General Public License v2.0
185 stars 41 forks source link

Web Search engine #104

Open AntoineTurmel opened 12 years ago

AntoineTurmel commented 12 years ago

Currently, typing on the address bar to search is broken. I have looked twice and don't know how to fix it to make it use keyword.URL

By default we can integrate a web search using the current search box at the top right corner. Either Seeks or DuckDuckGo is fine for me.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/783199-web-search-engine?utm_campaign=plugin&utm_content=tracker%2F230233&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F230233&utm_medium=issues&utm_source=github).
freaktechnik commented 12 years ago

I vote duckduckgo since it's pretty popular on linux ditros and I just like it.

ilikenwf commented 12 years ago

Same here.

AntoineTurmel commented 12 years ago

So we can go partnership with DuckDuckGo: http://help.duckduckgo.com/customer/portal/articles/775109-partnerships

I started a basic add-on to add the search engine: https://github.com/nightingale-media-player/nightingale-addons/downloads

But if we decide to partnership we have to consider several things:

How do the basic user search for content ? Currently we only have the search-bar working. A basic user is more looking for URL keyword search or "Google".

Can we add other ways to search ? I would suggest an "homepage" just like POTI did in the beginning, with a search box and a node link in the service pane (at the left of Nightingale). It could be also a search box when the user opens a new tab, but we have to make sure to add the newtab button first by default. (Philips is doing it)

freaktechnik commented 12 years ago

I don't like the idea of adding a node to the service pane, since the service pane shows media related stuff and opens content in the media tab. Web search clearly isn't media related. Thus I suggest using a custom newtab page and adding the newtab button by default.

rsjtdrjgfuzkfg commented 12 years ago

Agree with @freaktechnik that we should not include non-media stuff into the service pane...

AntoineTurmel commented 12 years ago

For me the service pane is for "services" so everything that can be opened in the main view such as media and web stuff.

http://forum.getnightingale.com/thread-602.html

ilikenwf commented 12 years ago

I don't care personally. Just make bookmarks an addon and addons can dictate then what it is used for.

rsjtdrjgfuzkfg commented 12 years ago

@GeekShadow and that's why I dislike having a (non-removeable) search link there, as it would open a new tab (or be inconsistent).

AntoineTurmel commented 12 years ago

@mook @rsjtdrjgfuzkfg Any idea on how to fix the URL Location bar to get search working with keyword.URL like in Firefox ?

rsjtdrjgfuzkfg commented 12 years ago

@GeekShadow nope, never looked at that...