search

nightingale-media-player / nightingale-hacking

Working tree for the community fork of Songbird, Nightingale. If building, use the sb-trunk-oldxul (development) branch, with the tag 1.12.1 tag for stable, for now. The master-xul-9.0.1 branch is the current progress in building Nightingale with XULRunner 9 and builds, but is broken. All help in terms of patches and pull requests is welcome.
https://getnightingale.com
GNU General Public License v2.0
185 stars 41 forks source link

Cleanup Unity integration extension #251

Closed freaktechnik closed 10 years ago

freaktechnik commented 10 years ago

The unity integration currently holds some redundant code, including (des)activation of notifications.

johnmurrayvi commented 10 years ago

I've been looking at this but have had problems with the album art in the sound menu not showing up. It may be that the 'download' code is necessary to save the album art to a temp file? The main reason I'm speculating this is because I'm fairly certain the sound menu is supposed to be usable by web applications (Link to API), and also because I've tried passing a file:// URI, but no album art displays. I've been sick / been having migraines so I haven't had a chance to work on it the past few days, but I'm better now and should be able to look at it again soon.

freaktechnik commented 10 years ago

Don't you worry, I've got an MPRIS2 extension up my sleeve, ready to replace Unity integration. And it will give integration to so much more...

johnmurrayvi commented 10 years ago

I got it working... I was being dumb. I cleaned up the album art code and removed the extraneous notification code left over before the libnotify extension.

In terms of "nightingale staying open" after clicking the close button on the window. It's actually a preference, "Hide On Close", so that you can just use the sound menu controls without having an extra window open at the time. The problem is, the preference isn't changeable from a user's perspective, i.e. #250.