search

nightingale-media-player / nightingale-hacking

Working tree for the community fork of Songbird, Nightingale. If building, use the sb-trunk-oldxul (development) branch, with the tag 1.12.1 tag for stable, for now. The master-xul-9.0.1 branch is the current progress in building Nightingale with XULRunner 9 and builds, but is broken. All help in terms of patches and pull requests is welcome.
https://getnightingale.com
GNU General Public License v2.0
185 stars 41 forks source link

Changed "it's" to "its" in the License Agreement and other places #363

Closed ianfixes closed 9 years ago

ianfixes commented 9 years ago

A grammar mistake in the first window that the user sees seems unprofessional.

screen shot 2015-09-13 at 10 16 52 am

I patched the license text into terms I could accept.

freaktechnik commented 9 years ago

Looks good, thanks! The only thing we might or might not want to do is modify naturaldocs (which we don't use anyways, but it's in the tools folder), I'm not sure there.

ianfixes commented 9 years ago

Let me know when you know one way or the other. Cherry-picking the first 2 commits should get you the most important stuff.

rsjtdrjgfuzkfg commented 9 years ago

Looks good to me as well. @freaktechnik agree on the naturaldocs thing; but we might consider removing it, or is there anything depending on that?!

freaktechnik commented 9 years ago

Natural docs was used to build the remote version of the Remote API docs, afaik, maybe @AntoineTurmel can confirm or deny that.

freaktechnik commented 9 years ago

Thanks for the patch! (and sorry for the delay in merging)

ianfixes commented 9 years ago

Glad to help :)