search

nightingale-media-player / nightingale-hacking

Working tree for the community fork of Songbird, Nightingale. If building, use the sb-trunk-oldxul (development) branch, with the tag 1.12.1 tag for stable, for now. The master-xul-9.0.1 branch is the current progress in building Nightingale with XULRunner 9 and builds, but is broken. All help in terms of patches and pull requests is welcome.
https://getnightingale.com
GNU General Public License v2.0
184 stars 42 forks source link

NG defaults to writing Comment metadata in ID3v1.1 instead of ID3v2.x #370

Open hobbsilla opened 8 years ago

hobbsilla commented 8 years ago

If I make changes to a files Comment metadata using NG's metadata editor it defaults to writing in ID3v1.1 and erases the Comment metadata in the ID3v2.x (tried this and replicated it with ID3v2.2, 2.3 and 2.4) and will cut itself off after 30 characters. If I delete all of the metadata from ID3v1.1 and then try this NG duplicates all of the data from the 2.x metadata and does the same thing as described above. In addition to this is also seems to create a blank Disc Number in ID3v2.x metadata if it didn't have one before. The Disc Number tick isn't that big of deal in comparison to the comments metadata complaint but it would be nice if both could be addressed together. I used the latest version of kid3 at the time of this post to confirm the changes being made by NG.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28829894-ng-defaults-to-writing-comment-metadata-in-id3v1-1-instead-of-id3v2-x?utm_campaign=plugin&utm_content=tracker%2F230233&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F230233&utm_medium=issues&utm_source=github).
hobbsilla commented 8 years ago

Oh yes. I'm using El Capitan OSX with NGale 1.12.1 build 2454, installed it from the standard dmg file and these two issues were not something I had observed with previous versions.

mook commented 8 years ago

I believe this was originally for Windows XP compatibility (Explorer's built in metadata handling only read id3v1). It is probably time to revisit that.

freaktechnik commented 8 years ago

I knew @rsjtdrjgfuzkfg at some point said something about ID3 versions and windows explorer... http://forum.getnightingale.com/thread-1012-post-4507.html#pid4507

rsjtdrjgfuzkfg commented 8 years ago

The question is why did the behaviour change? Is that a build without the recent taglib? As iirc the recent taglib might additionally write ID3v1, but we internally use ID3v2.4 (and that should also be written to the file).

hobbsilla commented 8 years ago

Since it sounds like I'm not alone in this problem would NGale contributors and developers be interested in pursuing a bounty if I created one?