nightingaleproject / VRDR_javalib

Java library implementation of the VRDR fhir standard http://hl7.org/fhir/us/vrdr/
Apache License 2.0
2 stars 1 forks source link

45 coding bugs in vrdr java library in DeathRecordvoidMessage.java and DeathRecordUpdateMessage.java #50

Closed consultantusa closed 1 year ago

consultantusa commented 1 year ago

My understanding based on forwarded Aihua Tong's email with git diff snippet is that the following worked for her previously?:

if (value != null && value > 0) { messageParameters.addParameter("block_count", new IntegerType(value)); }

johnarleyburns commented 1 year ago

But it should be UnsignedIntType and not IntegerType to match the FHIR type in the IG?

On Wed, Jun 14, 2023 at 10:39 AM Thomas Nguyen @.***> wrote:

My understanding based on forwarded Aihua Tong's email with git diff snippet is that the following worked for her previously?:

if (value != null && value > 0) { messageParameters.addParameter("block_count", new IntegerType(value)); }

— Reply to this email directly, view it on GitHub https://github.com/nightingaleproject/VRDR_javalib/pull/50#issuecomment-1591501920, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC77B6DLWNBPUWNGNXF5J3XLHLKFANCNFSM6AAAAAAZGOMV2M . You are receiving this because your review was requested.Message ID: @.***>