search

nightingaleproject / VRDR_javalib

Java library implementation of the VRDR fhir standard http://hl7.org/fhir/us/vrdr/
Apache License 2.0
2 stars 1 forks source link

In-Constructor References shouldn't be id only #74

Open MikeRileyGTRI opened 8 months ago

MikeRileyGTRI commented 8 months ago

Here's a constructor example from MannerOfDeath

    public MannerOfDeath(CodeableConcept manner, Decedent decedent, Certifier certifier) {
        this();
        setValue(manner);
        setSubject(new Reference(decedent.getId()));
        this.addPerformer(new Reference(certifier.getId()));
    }

With this subject reference setter; the decedent reference will only contain the id. Since 100 percent of the time; these resources are enclosed in a bundle; the references themselves should be resource provisioned; like "Patient/1234". This is a simple fix that needs to help the user with convention.