search

nightingaleproject / vital_records_fhir_messaging_ig

FHIR IG Specification For Vital Records FHIR Messaging
MIT License
3 stars 0 forks source link

`block_count` data type #14

Open whichwit opened 1 year ago

whichwit commented 1 year ago

This is related to void message validation. block_count is defined in the IG as unsignedInt, which allows 0. However the default interpretation, in the event block_count is null, should be 1 according to the IG. When 0 is passed as the value, does it mean no records should be voided? If 0 is not a valid business value, is positiveInt the more appropriate data type?

https://github.com/nightingaleproject/vital_records_fhir_messaging_ig/blob/508d61504d22ea455326ffe98f5308230143b6ae/input/fsh/SD_DeathMessageParameters.fsh#LL31C45-L31C45

saulakravitz commented 10 months ago

Good question/comment Le, Yes, block_count should have been positiveInt. But I'm not sure it is worth changing the IG.
NCHS currently interprets block_count absent, block_count=0, and block_count=1 the same way.