nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)
https://wiki.aaps.app
GNU Affero General Public License v3.0
725 stars 1.76k forks source link

max_iob = 0 after upgrading to AAPS 3.1.0? Maybe due to new objectives questions? #1947

Closed dhermanns closed 2 years ago

dhermanns commented 2 years ago

Looks like there are new objectives questions. After upgrading to 3.1.0 they showed up:

aaps-objectives

And I noticed that the restriction to max_iob = 0 seems to apply: loop smb

I already noticed that when upgrading to 3.0.0.2. Answered the questions correctly. But that didn't seem to remove the max_iob restriction.

Now after upgrading to 3.1.0 there are more new questions. But I fear that even after answering them correctly, the restriction will still persist.

Any thoughts?

MilosKozak commented 2 years ago

what do you have in preferences?

dhermanns commented 2 years ago

Hi Milos! In preferences a max IOB of 9 is configured.

I answered all questions. Tried to uninstall/reinstall the version 3.1.0. Reimported the preferences.

All questions now stay as answered. But max_iob is still always 0 under the loop tab.

agniabakush commented 2 years ago

You should chech max iob value in AMA module. It seems APS apply min value even module is inactive

dhermanns commented 2 years ago

Thanks - this is configured to 9 too:

image

Chikibai commented 2 years ago

Autosens ist not checked on.

In objectives 3 (Ver. 3.1)there are new questions (not translated). I remember in Ver. 3.0.02 this questions are I:C Verhältnis...now splitted in Ver. 3.1

dhermanns commented 2 years ago

Double checked the objectives and turns out the COB questions are once more marked as unsolved :-/

Did a export/import after reinstalling. But looks like that doesn't run smoothly.

Chikibai commented 2 years ago

Are you on latest 3.1.0.2 Ver. 3.1.0 have bugs

dhermanns commented 2 years ago

Missed the new version yesterday ;-) . Now I updated. But still the same behavior. All questions still answered. But max_iob seems still stay at zero. Tried to update it both in AMA and SMB settings. But no change.

Looks like its still disabled as if the objective 3 questions still unsolved.

dhermanns commented 2 years ago

Looks like the LGS constraint seems to set my max_iob to 0:

Screenshot_20220724-205250

Thinking about disabling this constraint completely to see whether this helps.

Thinking of setting the MAX_IOB_LGS to 9.0 in the HardLimits.kt:

        //LGS Hard limits
        //No IOB at all
        const val MAX_IOB_LGS = 9.0

Would this have any bad side-effects?

dhermanns commented 2 years ago

I switched MAX_IOB_LGS to 9.0. Closed Loops seem to work as expected now.

One-million-dollar question is: Why thinks AAPS that the Loop should be in LGS Mode? Looks like a bug to me...

Chikibai commented 2 years ago

max_iob = 0 and LGS is part/target of objectives 6

dhermanns commented 2 years ago

Hm - maybe I should restart and reanswer objectives 6 then?

Which code does the objectives 6 check? I could try to deactivate it there and try to drilldown the real cause...

Sabr1naT1 commented 2 years ago

Hi @dhermanns, I have the same issue with max_iob, could you please give an update whether restarting objective 6 fixed it?

dhermanns commented 2 years ago

Hi! No, not yet. We need the closed loop badly right now. So it will take some time for me to reset objectives 6.

Did you had unanswered questions too before updating to a newer version?

Sabr1naT1 commented 2 years ago

Currently I'm on version 3.0.0.2. I did not update the app, just installed and did the objectives one after the other and I'm stuck at objective 7 right now, because max_iob is 0 no matter what i'm changing in the settings. I want to update on 3.1 on sunday and if this will not fix objective 7, then I'm going to restart objective 6

dhermanns commented 2 years ago

So you did a fresh answer of all questions using 3.0.0.2? Then my wild guess seems to be wrong and restarting objectives 6 won't help.

At least it would surprise me ;-). You could try make workaround. Works fine for me, but sure this is dangerous and comes with no warranty ;-)

Sabr1naT1 commented 2 years ago

Hi, after installing 3.1.0.2 today and importing my settings, I also had 3 unanswered questions in objective 3 (about COB, see screenshot). After answering them, I tried to finish objective 7. Additonal to "max IOB" appeared the point "Closed mode activated". And in the settings about Loop APS mode, I found the setting to change it from LGS to Closed Loop and - et voîla - objective 7 is green \o/ Screenshot_20220801-195639 Screenshot_20220801-201805

dhermanns commented 2 years ago

Great - thanks. I checked your last setting and totally missed that one. Didn't remember that you could completely deactivate the closed loop here, too.

So the missing objectives haven't been the cause. Case can be closed. Misconfiguration on my side ;-).