nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)
https://wiki.aaps.app
GNU Affero General Public License v3.0
724 stars 1.76k forks source link

Using Nsclient results in duplicate profileswitch events in NS and in AAPS #2030

Closed wootmasterslick closed 2 years ago

wootmasterslick commented 2 years ago

Reporting bugs

18 aug 2022 23:22

Upon enabling nsclient the already present profileswitch events become duplicated and are the uploaded to NS. Sometimes numerous copies form and impact functioning of the app. Only the profileswitches are affected. They are flooding the NS and AAPS with useless information and making the app less responsive. The times are sometimes also varying so that affects any autotune calculations one might do.

3.1.0.3

Pump accu Check Insight

log files are coming asap

done

Screenshots:

Discussion: https://discord.com/channels/629952586895851530/629952669967974410/1009953469127458896

Philoul commented 2 years ago

No impact on Autotune calculation done with AAPS plugin: for each BG value, Autotune use the active profile got from database to calculate basal rate (and associated IOB, Activity...)

wootmasterslick commented 2 years ago

No impact on Autotune calculation done with AAPS plugin: for each BG value, Autotune use the active profile got from database to calculate basal rate (and associated IOB, Activity...)

Do you not agree it is an issue?

Philoul commented 2 years ago

I think having 3 or more lines for each profile switch is an issue, we should have only 2 lines (one line for the request, and a second line for the profile switch done into the pump). But even if there is a bug, there is no impact on Autotune calculation (cf comment below in Issue's description)

The times are sometimes also varying so that affects any autotune calculations one might do.

MilosKozak commented 2 years ago

this should be resolved in AAPS dev and NS 14.2.6