nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)
https://wiki.aaps.app
GNU Affero General Public License v3.0
696 stars 1.7k forks source link

[DEV] Overlapping temp basals in history possibly causing wrong IOB #2251

Closed jbr7rr closed 1 year ago

jbr7rr commented 1 year ago

Build: 4b46ea8363-2022.12.04 Merged at: https://github.com/nightscout/AndroidAPS/commit/9a35579d66b8f01d0a5610d7485ced848e736f7e Pump Used: EOPatch Time: See screenshot (2022-12-04 18:23 and 18:03 would be times of interest)

I noticed basals not cancelling correctly (or not showing up in history at least) causing wrong IOB results. See screenshot: WhatsApp Image 2022-12-04 at 18 35 01

Logs: AndroidAPS_2022-12-04-jb.zip

Edit: Looking back at the history I see this happinging on older builds as well. Looking further back I also saw some instances of this behaviour with the Combo (new driver). Will start a DASH when this one needs changing and see if it happens there as well. Removing the EOPatch tag.

vanelsberg commented 1 year ago

Can not see the problem here. E.g. 17:38h 120m basal is replaced with a 5 min basal at 18:03h. Nothing wrong with that... Please explain?

jbr7rr commented 1 year ago

Can not see the problem here. E.g. 17:38h 120m basal is replaced with a 5 min basal at 18:03h. Nothing wrong with that... Please explain?

Please look again, the basal did not end it was overlapping. In fact AAPS was thinking it was still running, the IOB counter for the one at 18:18 was still going up every 5 min.

Here is another example, please note the end time of the first temp basal. It later then the next one started

Screenshot_20221205-012129

vanelsberg commented 1 year ago

Bot sure. I read this as 22:48h - Started temp basal of 0,30 E/u for 30 minutes 22:53h - Changed to basal to 0,00 E/u for XX minutes.

The "0 minuten" on your latest screenshot however looks weard unless it is followed with a new basal rate at 22:53?

Will double check my AAPS on this.

vanelsberg commented 1 year ago

Any relation with an overlapping problem that was solved for DASH? https://github.com/nightscout/AndroidAPS/issues/1597

MilosKozak commented 1 year ago

fixed by https://github.com/nightscout/AndroidAPS/commit/d261bbad09a04d854ee3169eaf927f5502d8c7a2