Omnipod "Pump" (Orange/EmaLink) battery age not shown (Not urgent)

nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)

https://wiki.aaps.app

GNU Affero General Public License v3.0

724 stars 1.76k forks source link

Omnipod "Pump" (Orange/EmaLink) battery age not shown (Not urgent) #239

Closed robertrub closed 2 years ago

robertrub commented 3 years ago

I have an Omnipod with an Orangelink.

AAPS 2.8.1.1 shows the battery level of the Orangelink, which is working :)

But, if I note (on the Actions page) Pump battery change with a date (today or before), the information is noted on the care portal but not shown in the actions page.

Orangelink battery is NOT the pump battery but it is the only necessary battery information needed with Omnipod.

As Orangelink is in beta testing, having the age of the battery shown will help giving them the necessary information too.

Screenshot_20210117-140905_AndroidAPS Screenshot_20210117-140839_AndroidAPS

vanelsberg commented 3 years ago

Confirming. Seeing this too.

ToreBj commented 3 years ago

andyrozman commented 3 years ago

OrangeLink is the only RL/RL-clone that we can read battery from...

And display you have shown, would show age of battery in pump (your case Pod). We can't read battery from Pod, so in this case age shouldn't be shown at all...

Displaying Battery level of OL, wouldn't be really correct here... Especially since we don't know how long we have used the battery on OL.

robertrub commented 3 years ago

Hi Andy

AAPS can "know" the battery age as we can set it with the pump battery change button (this is how NS calculates it).

I think that OL battery = pump battery idea is assumed as, as you said, you cannot know the % or do anything with the Omnipod pump battery.

It would be useful if AAPS could look in the treatments history and if it finds an entry "Pump battery change", it shows the battery age.

Tnx :)

vanelsberg commented 3 years ago

Suggestion on "battery age" (nicetohave):

For Omnipod (both DASH and EROS) "pump battery age" has no meaning. So the field could be hidden.
For RL devices "pump battery age" may have different meaning (RL=rechargeable vs OL=replaceable battery) so it would need additional complexity for showing something sensible. So I would suggest to also hide the field by default for RL devices.

(User could be interested in registering how long battery/charge for RL/OL/Other lasts. Maybe consider an option for the user to enable the field and manually reset battery age on charge or replacement through Actions?)

robertrub commented 3 years ago

Sorry, I don't agree on battery age for OL having no meaning. My OL arrives at 50% in about 1 month. Even though it says "50%", when I measure the battery voltages, they are on the low side and more importantly, OL has more disconnect/reconnect problems. I use the battery age in NS to know when I'll need to change the batteries. As we already have this information, it would be nice to show it ;)

As for DASH, no battery info is needed and, if possible, the "battery info" line should not be shown at all.

vanelsberg commented 3 years ago

@robertrub Agree that for OL battery age would make some sense. This could then be covered by the user option to enable the field?

(Just my personal view: Remembering battery percentage of OL on the EROS tab was quite accurate I mostly monitored this to determine battery health. Personally I had no interest in battery age - other then when testing OL to get and idea on how many days batteries would last - used pen-and-paper for that ;-)

Andries-Smit commented 2 years ago

For Omnipod EROS, the age should be working, when the "Change battery pump" action is performed. Change action button is only available for EROS when enabled through the preferences. For Dash battery section in action and overview status light will be hidden completely https://github.com/nightscout/AndroidAPS/pull/1328