nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)
https://wiki.aaps.app
GNU Affero General Public License v3.0
694 stars 1.7k forks source link

Master 3.2.0.1 Winter time open loop #2998

Open robertrub opened 11 months ago

robertrub commented 11 months ago

I got a message in AAPS telling that the loop was not closed as the winter time change was in 3 h (or something similar, I was half asleep...)

But, the UI showed the closed loop icon

Screenshot_20231029_035659_AAPS.jpg

And when I looked in the OpenSMB tab, nothing was selected (not even open loop)

Screenshot_20231029_035750_AAPS.jpg

And, strangely, I didn't get the usual "update time in DASH pod" messages....

The logs

AndroidAPS_LOG_1698548595820.log.zip

mtanjagithub commented 11 months ago

Check the docs. Other pumps This feature is available since AAPS version 2.2.

To prevent difficulties the Loop will be deactivated for 3 hours AFTER the DST switch. This is done for safety reasons (IOB too high due to duplicated bolus prior to DST change).

You will receive a notification on the main screen prior to DST change that loop will be disabled temporarily. This message will appear without beep, vibration or anything.

https://androidaps.readthedocs.io/en/latest/Usage/Timezone-traveling.html#time-adjustment-daylight-savings-time-dst

Op zo 29 okt. 2023 04:05 schreef Robrub @.***>:

I got a message in AAPS telling that the loop was not closed ad the winter time change was in 3 h (or something similar, I was half asleep...)

But, the UI showed the closed loop icon

[image: Screenshot_20231029_035659_AAPS.jpg] https://user-images.githubusercontent.com/76626474/278848600-7e19aad3-4ff4-45aa-a4a1-3c2bec4ea357.jpg

And when I looked in the OpenSMB tab, nothing was selected (not even open loop)

[image: Screenshot_20231029_035750_AAPS.jpg] https://user-images.githubusercontent.com/76626474/278848641-70a694b2-5934-47b9-86ce-b216d3620225.jpg

And, strangely, I didn't get the usual "update time in DADH pod" messages....

— Reply to this email directly, view it on GitHub https://github.com/nightscout/AndroidAPS/issues/2998, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6KTSVTJMUCCGNJBPP2FCX3YBW2WDAVCNFSM6AAAAAA6UQVK36VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DMOBSGM4TMOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

robertrub commented 10 months ago

Except the point above, it was the easiest summer/winter time change ever. No need to set pod time, no other messages etc :)

robertrub commented 10 months ago

@mtanjagithub Yes, I know the drill and the reason. That is NOT the "bug".

The strange/buggy (?) part is the icon, it says closed loop... And the loop selection just disappears.

Maybe adding a barred TZ or DST on the closed loop icon to represent the situation correctly would be better (for those who wake up in the middle of the might ;) )

olorinmaia commented 10 months ago

My input: I couldn't see a reason in SMB / DynISF tab tonight why loop wasnt working, maybe I was to tired to see where it was tho. So at first I thought it was a bug with DynISF that is new for us ;)

I had to see inside "Loop"-tab to see error message, "DST helper: DST in last 3 hours" isn't really self-explantory either. I can't remember getting any warning in AAPS.

Loop icon should turn red (disabled) and SMB/dynisf-tab should also show error why loop isnt working during these 3 hours. That may be easy to fix.

robertrub commented 10 months ago
 couldn't see a reason in SMB / DynISF tab tonight why loop wasnt working

Normally you had a message in AAPS telling that loop can't ve closed due to DST...

But agreed on the modified icon.