search

nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)
https://wiki.aaps.app
GNU Affero General Public License v3.0
690 stars 1.69k forks source link

Empty dialogue when logging CGM change via Action tab (minor cosmetics) #3265

Closed DM-LTR closed 5 months ago

DM-LTR commented 6 months ago

Issue: When user clicks the button for CGM Sensor insert, an empty dialogue appears and user has to select OK fot the second time. I am really not sure if this is intentional (to somehow alert or delay the user and make him to click OK twice), but there was an extra confirmation message before (sth. like "Do you really want to record a sensor change"? OR maybe "This option will record the sensor change.")

Replication: Go to Actions tab, select "CGM Sensor insert" - 1st dialogue appears (Event date and time), OK, then 2nd one (empty) appears, OK, done

https://github.com/nightscout/AndroidAPS/assets/43177472/dcba7d2e-9495-44e0-82de-4a1eb917fc32

jbr7rr commented 6 months ago

Please include AAPS version in issue

Philoul commented 6 months ago

On latest versions, it's not an empty dialog, you can tune date and hour of the event, and include a note (text information) (if Notes are enabled in Overview preferences) Then On all dialogs, you have a confirmation popup whatever the dialog (Insulin, Carbs, Notes, CGM...)...

DM-LTR commented 6 months ago

Please include AAPS version in issue

Sry. This issue is present for a long time. In this case master 3.2.0.3

MilosKozak commented 5 months ago

https://github.com/nightscout/AndroidAPS/commit/cd5df709f6639ee7112ab62fda6e8778e0e71010