search

nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)
https://wiki.aaps.app
GNU Affero General Public License v3.0
722 stars 1.76k forks source link

Enable SMB always while using xdrip in companion app mode and dexcom g7 original app #3266

Open Pentagit opened 7 months ago

Pentagit commented 7 months ago

When using xdrip (latest nightly) in companion app mode fetching bg values from dexcom g7 app, aaps (3.2.0.3) still won't allow SMB to be enabled always. Please fix so that g7 users can use latest dexcom g7 app including clarity and still have hcl/fcl possibility in aaps.

jbr7rr commented 7 months ago

Problem is that xDrip doesn't send which sensor the data comes from in companion app mode., so AAPS can't determine if it is data from G7 or e.g. a medtronic sensor So we need this information from xDrip when we want to enable it for ONE/G7 companion mode, I suggest you open a discussion/issue over at xDrip as well.

Pentagit commented 7 months ago

Thank you. I understand. I have posted this on xdrip repo: https://github.com/NightscoutFoundation/xDrip/discussions/3396

Though, why isn't AAPS enabling SMB always no matter which BG source xdrip is using? AFAIK, xDrip companion mode is available for the following vendor apps: G6 (master only) One (only if the app shows BG notifications) G7 (master only) CamAPS Guardian MiniMed Omnipod 5 app

Is any one of these apps a problem for always SMB in AAPS or why can't AAPS just enable it for the xdrip companion mode? But perhaps I'm misunderstanding something :)

jbr7rr commented 7 months ago

Though, why isn't AAPS enabling SMB always no matter which BG source xdrip is using? AFAIK, xDrip companion mode is available for the following vendor apps: G6 (master only) One (only if the app shows BG notifications) G7 (master only) CamAPS Guardian MiniMed Omnipod 5 app

For Dexcom we know that they have good filtering, meaning that when there are erroneous values the sensor/transmitter doesn't send them. For the others we don't know

Pentagit commented 7 months ago

Why no mandatory smoothing (average/exponential) then when using xdrip companion data?

jbr7rr commented 7 months ago

Why no mandatory smoothing (average/exponential) then when using xdrip companion data?

Dexcom does error detection, meaning it will not send data when there are erroneous values., with smoothing only there will still be a datapoint on the erroneous value, which can lead to wrong dosing. But this is already being discussed in other issues as well: https://github.com/nightscout/AndroidAPS/issues/3181 https://github.com/nightscout/AndroidAPS/issues/2121 https://github.com/nightscout/AndroidAPS/issues/2354