Negative carb entry doesn't sync between AAPSClient / AAPS

nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)

https://wiki.aaps.app

GNU Affero General Public License v3.0

694 stars 1.7k forks source link

Negative carb entry doesn't sync between AAPSClient / AAPS #3436

Open olorinmaia opened 1 week ago

olorinmaia commented 1 week ago

Just tested 9fe441bc - nice new feature!

When entering negative carbs in AAPS it doesn't sync to AAPSClient, neither the other way.

Tested with both v1 and v3 NSClient

vanelsberg commented 4 days ago

When entering negative carbs in AAPS it doesn't sync to AAPSClient, neither the other way.

Depends on the objective of entering negative carbs.

If it is used to prevent overdosing due to the fact that according to oRef calculations carbs correctly entered absorbe to slow I think the negative carbs should not be counted or sent to NS/appsclient/other. Carbs were actually taken!
If it is to modify carbs entered wrongly earlier, I do not think one should use negative Carbs for this.

Negative carbs is not ment for "correcting" the amount of crabs entered in the past. User can do this through the treatment Tab. ~~So I would argue this is not a bug?~~

olorinmaia commented 4 days ago

Many parents use AAPSClient boluscalculator to assess how much to bolus for. AAPS phone is often in pocket of child or perhaps in some cases not close by. Bolus can be delivered manually by sms or via watch connected to AAPS.

You can also have the situation that negative carbs are entered in AAPSClient, and AAPS COB doesn't get reduced.

It is very important that COB on AAPSClient and AAPS is synced. I cant see any reason why it shouldnt.

vanelsberg commented 4 days ago

It is very important that COB on AAPSClient and AAPS is synced. I cant see any reason why it shouldnt.

Ok. Yes. Then this is a bug...

Didn't think about remoting by parent (which obviously aapsclient is used for)