search

nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)
https://wiki.aaps.app
GNU Affero General Public License v3.0
728 stars 1.77k forks source link

[Dev 3.3.0-dev-d] Semi-tranparent dots mess up the glucose plot #3535

Open yhonatanb20 opened 2 days ago

yhonatanb20 commented 2 days ago

Using version 3.3.0-dev-d with xdrip-G7 as data source and average smoothing ON, some datapoints on the BG plot appear semi transparent, but in a kind of alternate way - this just complicates the graph... Screenshot_20241117_134312_AAPS

yhonatanb20 commented 2 days ago

I mean, look, this looks funny, right? Screenshot_20241117_195232_AAPS

parapenT1sta commented 2 days ago

Try with the latest commit: https://github.com/nightscout/AndroidAPS/commit/4373ecdde4a0fc3aaa3b74ae1b9da6a769007a4e

yhonatanb20 commented 2 days ago

Thanks @parapenT1sta, installed latest dev, still facing same issue

yhonatanb20 commented 1 day ago

@MilosKozak was commit 4373ecdde4a0fc3aaa3b74ae1b9da6a769007a4e meant to fix this issue?

MilosKozak commented 1 day ago

Transparent means recalculated gap

yhonatanb20 commented 1 day ago

So I suspected. But when using average smoothing half of the values are recalculated, this makes visualization very messy: Screenshot_20241118_101841_AAPS Knowing which values are recalculated is theoretically valuable, but practically it just makes the graph much less readable...

MilosKozak commented 1 day ago

well you should focus on why do you have so many gaps. this should be not common. for most people it's rare

MilosKozak commented 1 day ago

because there are original values visible on top of recalculated, expecting they are backfilled later

yhonatanb20 commented 1 day ago

well you should focus on why do you have so many gaps. this should be not common. for most people it's rare

These are not gaps in the readings, this results from the smoothing algorithms. I use Xdrip + G7, and "Average Smoothing or Exponential Smoothing MUST be enabled for meaningful use of the G7 / ONE+ values." It is my understanding that this way inevitably many values will be "smoothed". Most values were recalculated by the native BYODA algorithm back on G6, right? But this did not affect visualization in AAPS because it wasn't an AAPS smoothing plugin, and I don't feel I lost valuable information there because of all points being opaque.

MilosKozak commented 1 day ago

image At time of receiving this value, previous were missing. Otherwise it would be not transparent

yhonatanb20 commented 1 day ago

image At time of receiving this value, previous were missing. Otherwise it would be not transparent

Two slightly updated screenshots:

Screenshot_20241118_104127_AAPS Screenshot_20241118_104835_AAPS

These transparent points change places all the time, it has nothing to do with missing values, the communication between G7 - XDrip - AAPS is fine, this does not represent backfilling.

t1dude commented 6 hours ago

I can confirm the same issue with G7 -> xDrip (companion mode) -> AAPS.