nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)
https://wiki.aaps.app
GNU Affero General Public License v3.0
694 stars 1.7k forks source link

Dana I not showing TDD #862

Closed pbloom209 closed 2 years ago

pbloom209 commented 2 years ago

Reporting bugs

Using Beta3 ver 4 and previously ver3 Used these versions from the time they have each been released. Using Dana I Same pump all the way through.

I find that it does not total the units for TDD.

https://user-images.githubusercontent.com/37948551/140643805-061f8f65-38e6-47a1-88d6-16b27652a0b1.mov

Philoul commented 2 years ago

How many days do you have in aaps database? TDD is not calculated with pump informations, but with data recorded in aaps database...

MilosKozak commented 2 years ago

fixed by https://github.com/nightscout/AndroidAPS/commit/3bbf50ca3e3193c99f860885b29db57e4d2fffd6

pbloom209 commented 2 years ago

I did the code change and reinstalled.

I ran the TDD after a few hours. See attached. Seems to be the same issue

https://user-images.githubusercontent.com/37948551/140664175-c43919c3-cff4-4619-b5a1-3a1ed28484eb.mp4

.

MilosKozak commented 2 years ago

try it after one day

mxsrm commented 2 years ago

@MilosKozak The issue is not fixed (3.0-beta9): after one day it will only show the TDD for the day that has passed, not the rest:

Screenshot_20211206-120147

DanaRS v3. After pressing "RELOAD" it loads the values from the pump but does nothing with it.

@Philoul If that is the case, why does it connect to the pump? If I remember correctly this worked in the past?!

MilosKozak commented 2 years ago

i checked it again and it works with Dana-i wait at least 2 days after you changed pump

mxsrm commented 2 years ago

@MilosKozak After 3 days it still does not show more than the days that AAPS has data for anyway; nothing that is loaded from the pump is used:

https://user-images.githubusercontent.com/7951225/145269035-3295e816-473e-4276-b43d-d37fa29bbf55.mp4

MilosKozak commented 2 years ago

do you see TTD in pump? on video there is no recent data comming visible

mxsrm commented 2 years ago

Yes, the pump shows normal data as far back as I want (checked till start of november). After 6 days it still only shows data that AAPS collected itself.

PXL_20211213_132323604

mxsrm commented 2 years ago

Pump history browser shows the data without problem, it's just never used in TDD tab:

Screenshot_20211213-142735

MilosKozak commented 2 years ago

ok. reload history from AAPS and provide logs. we'll see

MilosKozak commented 2 years ago

be sure you are using latest version

mxsrm commented 2 years ago

be sure you are using latest version

Beta or dev?

MilosKozak commented 2 years ago

there is no difference from this point of view

mxsrm commented 2 years ago

Log using beta9:

AndroidAPS.log

MilosKozak commented 2 years ago

i see loaded data 5/12 - 12/12

mxsrm commented 2 years ago

For all older entries it just notes

18:04:56.867 [main] D/CORE: [TDDStatsActivity.onResume$lambda-18():209]: EventDanaRSyncStatus: 05/12/2021 00:00 dailyinsulin
18:04:56.915 [Binder:15993_3] D/PUMPBTCOMM: [BLEComm.processMessage():859]: <<<<< REVIEW__DAILY B2 12 03 15  0C 04 03 B6  14 50 18 06
18:04:56.918 [Binder:15993_3] D/PUMPCOMM: [DanaRSPacketHistory.handleMessage():137]: History packet: 3 Date: 04/12/2021 00:00 Code: 80 Value: 6150
18:04:56.925 [Binder:15993_3] E/PUMP: [PumpSyncImplementation.confirmActivePump():83]: Ignoring pump history record  Allowed: 04/12/2021 14:36:34 DanaRS TKK00197FB Received: 1638572400000 04/12/2021 00:00:00 DanaRS TKK00197FB

"Ignoring pump history record Allowed: 04/12/2021 14:36:34" so it discards all data before the new install of AndroidAPS started?

MilosKozak commented 2 years ago

only data from settin up pump in AAPS is accepted do you see these 7 days?

mxsrm commented 2 years ago

Yes the days since setting up AAPS are displayed correctly. I wasn't aware, that the days before are not taken into account. Then it works as intended.