nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)
https://wiki.aaps.app
GNU Affero General Public License v3.0
724 stars 1.76k forks source link

Dev / BYODA v1.9 : Calibration in BYODA give double readings in AAPS #953

Closed robertrub closed 2 years ago

robertrub commented 2 years ago

Screenshot_20211116-213207_AndroidAPS

I have installed the new version 1.9 of BYODA. All was working OK till I got the red triangle when I calibrated this morning. I saw that in the Dexcom tab, there were 2 same readings at the time of the calibration

Screenshot_20211119-074210_AndroidAPS

20211119_075028

Deleting of the readings cancelled the red triangle

AndroidAPS_LOG_1637304353677.log.zip .

MilosKozak commented 2 years ago

2nd timestamp is not visible . do you still have it?

swissalpine commented 2 years ago

Could AAPS delete double entries when they come in (condition for example: same bg, same delta, timestamp < 60 sec)?

MilosKozak commented 2 years ago

there is a wide range of CGM producing different data. so far i'm trying to find setup which doesn't produce duplicates instead of cheating/filtering on AAPS side (which may work for one CGM but not for others. or filter out valid readings)

robertrub commented 2 years ago

2nd timestamp is not visible . do you still have it?

Sorry, nope. I hadn't realized that the text was longer than the windows.

It could be better f the text was shorter and more explicit.... ;)

vanelsberg commented 2 years ago

I can see how upgrading BYODA could result in duplicates: The new version does not have any history of it predecessor: it just read the memory of the transmitter containing several hours of BG data and dump all to APPS?

@robertrub I assume you did you upgrade on a new sensor?

robertrub commented 2 years ago

@vanelsberg The duplicate issue I opened was for calibration, not for general use.

To answer your question: i changed from 1.7 to 1.9 towards the end of the 2h wait period (no BGs for 2h) of a sensor restart and I didn't have any duplicates.

robertrub commented 2 years ago

@MilosKozak More testing on BYODA calibration (v1.9) : I did the same things at +3 min after last BG reading at at +4 min after last reading and the first did NOT give a double BG value and the 2nd did give a double value. Several messages on Discord gives the same impression of this bug being time related to the last BG reading.

Open BYODA by its own icon, calibrate in BYODA and see what happens in AAPS. The attached log with double BGs in AAPS. Look around 8:47. The BGs in BYODA (and AAPS of course) were higher than the real blood tests.

Screenshot_20211204-084837_AndroidAPS

AndroidAPS_LOG_1638604271854.log.zip