Dash: remove the 'suspend delivery' button

nightscout / AndroidAPS

Opensource automated insulin delivery system (closed loop)

https://wiki.aaps.app

GNU Affero General Public License v3.0

694 stars 1.7k forks source link

Dash: remove the 'suspend delivery' button #958

Closed avereha closed 2 years ago

avereha commented 2 years ago

I'm opening this issue so we could discuss the idea of removing the 'suspend delivery' button for Dash. 'Disconnect pump' does set a zero TBR and has the advantage that delivery will be resumed automatically.

Is there are any good use-case or reason to keep the 'suspend delivery' button?

robertrub commented 2 years ago

Disconnect pump is safer as it turns basals back on after x minutes. Can't see where more than 3h of disconnect would be utilized.

Suspend button can be deleted from the DASH tab.

vanelsberg commented 2 years ago

Was using the suspend button in favor of "disconnecting the pump" from AAPS. I do feel the suspend is not identical with "disconnect": warning every 15 minutes, letting Dash fall back to default basal rate.

However, after some discussion, I do think removing the suspend/resume buttons from the DASH driver is a good idea:

The driver suspend is conflicting with Profile switch as you pointed out.
Standard AAPS functionality is on the main overview. Having an additional ways to "disconnect" adds confusion.
AAPS's "disconnect" automatically "reconnects" the pump after 3 hours (@robertrub)

So yes, I would say you have a sound reason on removing suspend/resume.

robertrub commented 2 years ago

@avereha Be sure to keep the "Resume" delivery function/button though. If a profile change doesn't get trough and the pod stays "stuck" in suspended" mode, the user should be able to "Resume" insulin delivery.

EDIT: Seems that you have this already covered with @freloner.

avereha commented 2 years ago

This can be closed yes, the 'resume' button will still be there!