search

nightscout / Trio

MIT License
64 stars 259 forks source link

Add SMB flag and display SMBs in history. #101

Closed BrianWieder closed 4 months ago

BrianWieder commented 4 months ago

Based on https://github.com/Artificial-Pancreas/iAPS/pull/219 for #47.

Creates a new flag for isSMB and displays SMBs similar to external insulin within the history sheet. In a follow-up PR, will cleanup the History list.

simulator_screenshot_291702D7-4AF7-46C7-9AD2-15300A85F83B

avouspierre commented 4 months ago

I wonder about the creation of the variable versus event.type. Why don’t use the event.type with a new type for example .automaticBolus ?

in fact same question with isexternalbolus where there is a new variable and a new type of event. What’s the interest because the risk of divergence could be a issue…

avouspierre commented 4 months ago

Tested in alpha version with success. OK for me.

My previous comment was resolved with PR #110