search

nightscout / Trio

MIT License
64 stars 259 forks source link

Update HomeRootView.swift #105

Closed nicolevanelstvandenhoek closed 3 months ago

nicolevanelstvandenhoek commented 4 months ago

Used more style full icons from SF-Symbols.

MikePlante1 commented 4 months ago

Looks like this is what's changed by the PR: (EDIT: screenshots from iPhone 15 simulator)

new-light new-dark

Currently dev looks like this:

old-light old-dark
bjornoleh commented 4 months ago

Thanks for the suggestion. We have agreed to not change anything UI related before the first release, simply because we are short on time and UI changes tend to take time and divert attention from more pressing matters. Let’s revisit this a little later 😊

nicolevanelstvandenhoek commented 4 months ago

I understand that it is not a priority. Therefore, it is very good that those who do the content development deal with the more complicated stuff. I don't have that knowledge, but I do have a lot of feel for the UI and thus can't disrupt much of the real development work either. In short, I have the time and inclination to help work on a nice UI.

Sjoerd-Bo3 commented 4 months ago

I understand that it is not a priority. Therefore, it is very good that those who do the content development deal with the more complicated stuff. I don't have that knowledge, but I do have a lot of feel for the UI and thus can't disrupt much of the real development work either. In short, I have the time and inclination to help work on a nice UI.

Thanks great, But it also means that it probably won't make it in before 1.0.0 . A whole rework is coming after 1.0.0 aswell.

dnzxy commented 3 months ago

To give constructive criticism to this PR:

The insulin vial icon is skewed. That is due to using .frame(width: 24, height: 24) with SF Symbols. Please refrain from doing that and style, i.e. set icon sizes, by using font size, as SF Symbols "behave" just like fonts.

Just as an example:

Image(systemName: "cross.vial.fill").font(.system(size: 25))

Is it okay if we close this PR here for now?

dnzxy commented 3 months ago

Closing for now with 2 thumbs up, one by PR author. Thanks guys.