Add a separate setting for Sigmoid Adjustment Factor vs Logarithmic Adjustment Factor

[MikePlante1]

I think a new setting should be added for Adjustment Factor so Logarithmic DynamicISF can default to 0.8 and Sigmoid DynamicISF can default to 0.5. This prevents new users from starting DynamicISF in Logarithmic mode with a default of 0.5 which seems to often lead to prolonged highs for many people. Also helpful for those who switch between Logarithmic and Sigmoid depending on their situation.

[MikePlante1]

I started playing around with it, but am not too confident about the oref side of things. Here's all I've got so far (let me know if you want access to view it): https://github.com/nightscout/Open-iAPS/compare/dev...MikePlante1:Open-iAPS:separate_adjustment_factors

[MikePlante1]

Opened PRs https://github.com/nightscout/Open-iAPS/pull/114 and https://github.com/nightscout/open-iaps-oref/pull/21 to address this issue.

[bjornoleh]

This looks very reasonable for both repositories, and I agree that we need this. I have only looked at the PRs superficially so far.

[MikePlante1]

I’ve only loosely tested this in a simulator so far, by the way, so more thorough testing should be done before approving.

[MikePlante1]

Closing this issue since https://github.com/nightscout/open-iaps-oref/pull/21 and https://github.com/nightscout/Open-iAPS/pull/114 are merged into dev