search

nightscout / Trio

MIT License
64 stars 259 forks source link

Libre not uploading new SAGE to nightscout #108

Closed kylmcw closed 4 months ago

kylmcw commented 4 months ago

Freestyle Libre SAGE is not uploading to nightscout at all.

bjornoleh commented 4 months ago

SAGE upload to NS was introduced in iAPS here: https://github.com/Artificial-Pancreas/iAPS/commit/2d60ffcc690700c0ffe1c3879c3fc14092b8aace#diff-d6569af4c16ca2e28f1ea9edccf5b7693c1b4b61935bdb870c106567ecb04d63

This includes changes to two files in the Dependencies directory which are deleted from the submodule based OiAPS (alpha):

Dependencies/LibreTransmitter/Sources/LibreTransmitter/LibreSensor/SensorContents/SensorData.swift Dependencies/LibreTransmitter/Sources/LibreTransmitter/LibreTransmitterManager.swift

To make SAGE uploads happen in submodule based OiAPS, we would probably need to fit this in elsewhere, or make the required PR to https://github.com/LoopKit/LibreTransmitter.

I don't know if SAGE upload was implemented already in Loop? I think not, although it has been discussed previously. @marionbarker would probably know.

avouspierre commented 4 months ago

To review in alpha

kylmcw commented 4 months ago

SAGE verified uploaded to Nighscout on Alpha branch.

image

bjornoleh commented 4 months ago

Fixed in #112