search

nightscout / Trio

MIT License
64 stars 259 forks source link

Update submodule OmniBLE and OmniKit #122

Closed bjornoleh closed 4 months ago

bjornoleh commented 4 months ago

git submodule: a92e9752994e7b143cdb007d3c7bcba0c0cc9214 CGMBLEKit (v3.1-166-ga92e975) eba7d98b9a7995f50209f14f20cc1ac779b330ea G7SensorKit (heads/main) c01eba63e94e9f6f2841a8835680c4e39c61b18d LibreTransmitter (heads/main) 2f535b3ca46825e82e0dd1b5ef9daccd53a3f0ca LoopKit (v3.0-1039-g2f535b3) aa82a184e8243d30dc3b488ae17fd31602a3bd80 MinimedKit (heads/main-5-gaa82a18) e15b18796a6ac0a08851b4ca2924cec669d669c5 OmniBLE (heads/dev) 30428b78809bf816b12b01ca2a05eb843ab46c99 OmniKit (heads/main) a0e419da314d0ad42b41ccb04af73cd1fbf41257 RileyLinkKit (heads/dev) a2ccad72a55600c28549ab86ab1964c0d6558868 TidepoolService (heads/dev_rc) 21d8657d727f26df76342188e580022bf4884714 dexcom-share-client-swift (v0.4.1-156-g21d8657)

marionbarker commented 4 months ago

Can you hold off a day or two. There are 3 PR (2 for OmniBLE and 1 for OmniKit) that I plan to merge in the next day or so. The SHA will be updated when these are merged and will be in dev and main respectively. The odds of the missing commit for OmniBLE hitting anyone in real life is microscopic (fixes hang when app restarts between 0x03 and 0x08 messages). I only saw it a couple of times in dozens of tests where I was deliberately quitting out of Loop when trying to set up a new pod using the DASH rPi simulator. I had to set a breakpoint in the code for us to be able to trigger it when I tried to reproduce the problem so we could fix it.

These are the next 3 PR I plan to merge - probably tomorrow:

marionbarker commented 4 months ago

And those 2 appName commits only affect the Uncertain Recovery screen that is not used by Open-iAPS anyway. So won't affect the translation strings.

marionbarker commented 4 months ago

I confirm this brings in the latest OmniBLE and OmniKit versions.