nightscout / Trio

MIT License
64 stars 259 forks source link

Browser Build Update: Complete the Scheme rename and update to Fastlane 2.220.0 #130

Closed marionbarker closed 3 months ago

marionbarker commented 3 months ago

This is an alternative to PR #127:

@bjornoleh might choose to break this into separate PRs. I am putting it all in one place for review and testing.

Testing:

See https://github.com/marionbarker/Open-iAPS/actions for various failures and successes

  1. start with a username and repo that are all configured for Browser Build (known good secrets)
  2. confirmed that Validate Secrets using alpha branch fails (needs Fastlane update)
    • The consequence is you cannot do a Browser Build with alpha branch when Validate Secrets fails
    • This error was first reported on FB for LoopWorkspace - dev on April 14
    • The proposed solution is to update Fastlane version to 2.220.0
  3. confirmed that Validate Secrets using new-scheme-update-fastlane succeeds
  4. Keep going until I get a successful build - here are the steps I took:
    • forgot to add app group to LiveActivity - fixed that, reran certs
    • renamed scheme in Fastfile and pushed the commit
    • error was malformed Package resolved - reverted the inadvertent change and pushed the commit
    • got a successful build - very excited - loaded it on the phone (see graphic)
  5. Update the output_name from "iAPS.ipa" to "Open-iAPS.ipa"
    • this build failed at the testflight update portion because I needed to change to "Open-iAPS.ipa" in two places
    • commit the second change and try again
    • go on and open the PR assuming this will work
    • Edited to add: the browser build / testflight upload succeeded

open-iaps-rename-scheme-update-fastlane

marionbarker commented 3 months ago

Tested the "round-trip". Fresh download into folder in correct location to read the apple id information automatically.

git clone --branch=new-scheme-update-fastlane --recurse-submodules https://github.com/marionbarker/Open-iAPS.git
cd Open-iAPS
xed .

Initial XCode screen:

initial-xcode-screen-fresh-download

Hit Play and it built onto the phone successfully.

marionbarker commented 3 months ago

Closing this because it will be handled as two separate PRs.