Closed marionbarker closed 3 months ago
@marionbarker, have all these "leftovers" been fixed by #148?
Here are some links for your review:
refers to widgetURL(URL(string: "freeaps-x://"))
refers to a loopandlearn dot org page that I don't think exists anymore
The same phrase is in all the strings files too.
Other than this, I believe the left-overs are taken care of.
Here are some links for your review:
refers to
widgetURL(URL(string: "freeaps-x://"))
Thanks.
The url string can be updated to the hardcoded "Trio-x://". But we should probably use $(APP_URL_SCHEME) instead. Will have to test before making a PR. If someone wants to pick that up before me, please go ahead.
https://github.com/nightscout/Trio/blob/f23b38ad8b1ca3865ffc56482bf6c6740cad8ecf/Config.xcconfig#L9
refers to a loopandlearn dot org page that I don't think exists anymore
The same phrase is in all the strings files too.
Other than this, I believe the left-overs are taken care of.
Perhaps this is something for @t1dude to look at, to get to grips with how we best make changes to strings that are translated, now that Crowdin is being set up.
@MikePlante1 , I am not sure what this does. I assumed it was to open the app when tapping the Live Activity, but that works also when URL(string: "freeaps-x://"
I made the PR #197 anyways, for completeness. (replacing the old URL(string: "freeaps-x://"
)
Closing this as completed now that PR #197 is merged.
refers to a loopandlearn dot org page that I don't think exists anymore
The same phrase is in all the strings files too.
Other than this, I believe the left-overs are taken care of.
Perhaps this is something for @t1dude to look at, to get to grips with how we best make changes to strings that are translated, now that Crowdin is being set up.
@marionbarker , the LnL link is not fixed yet, but probably will be when #216 is merged.
These are nits - just providing this list so they are available for update when and if desired.
I am testing only alpha branch (soon to be dev). Configuration: commit 99effeb7
This is a plist file so a little different:
<string>com.artificial-pancreas-iaps</string>
The rest of these are in *.swift files and indicate the line numbers where hard-coded "iAPS" exists:
StateiAPSResults
, see next file)Note: many of the rest of these should (later) be modified to use appName instead of hard coded string
Hard-coded string from iAPS to Open-iAPS
Hard-coded string from FAX to Open-iAPS