search

nightscout / Trio

MIT License
64 stars 259 forks source link

Rename watch app scheme to Open-iAPS_WatchApp.xcscheme #138

Closed bjornoleh closed 3 months ago

bjornoleh commented 3 months ago

Complements #127

bjornoleh commented 3 months ago

This PR is just a rename of the build scheme for the watch app. I expect it to be fine, but a second set of eyes or another test build would be nice. It did build fine to simulator in Xcode 15.0.

marionbarker commented 3 months ago

Not sure this rename is required; but I think it's ok if we want to do it.

Successful Tests:

Unsuccessful Tests:

My watch is Series 7 running watchOS 10.4. Is there a Series 8 requirement?

xocde-to-watch-direct

Sjoerd-Bo3 commented 3 months ago

Not sure this rename is required; but I think it's ok if we want to do it.

Successful Tests:

  • Configuration 1:

    • I built alpha branch, commit aa55271 onto my real phone and added watch app to my real watch.
    • It shows up as Open-iAPS on the watch app list.
    • Looks ok on watch

  • Configuration 2:

    • Downloaded the patch and applied it. Rebuilt. Deleted app from watch, reboot watch, add app again.
    • It shows up as Open-iAPS on the watch app list.
    • Looks fine.

  • Configuration 3:

    • With patch applied, build to simulator and then build direct to simulated watch
    • Looks fine.

Unsuccessful Tests:

My watch is Series 7 running watchOS 10.4. Is there a Series 8 requirement?

  • Direct Xcode to Watch using iAPS_WatchApp:

    • Deleted app from watch.
    • Tried to installed from Xcode using Open-iAPS_WatchApp scheme onto watch directly but it claims my watch is not valid ( see graphic below)
  • Restored to original (unpatched) version

  • Direct Xcode to Watch using FreeAPSWatch:

    • same error

xocde-to-watch-direct

Thats odd, it also says that your series 7 is still on watchOS 8, but it isn’t right?

marionbarker commented 3 months ago

Please close this PR. I will take care of it in the update name to Trio PR currently being prepared.